Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble docking adjustment #2415

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Bubble docking adjustment #2415

merged 5 commits into from
Nov 17, 2023

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Oct 20, 2023

Adjust mobile docking port to ensure east facing, added stationary docking port.

About The Pull Request

The Bubble lacked a docking port for shuttles, and would rotate in flight.

Expanded map height (Y) by one to fit stationary dock. Added stationary dock to south airlock for shuttle use:
Weaver Lambda AB 2023-10-19 055811

Moved mobile dock to north pad and corrected preferred_direction (was north!) and port_direction. This ensured east-facing during transit.

With the expanded map height (Y), Bubble map was now a square and would land facing north. Expanded map length (X) to make it rectangular again, and now it correctly lands facing east.

Why It's Good For The Game

Shuttle docking adds options. Consistent ship facing prevents issues.

Changelog

🆑
tweak: Bubble now consistently faces east
add: added Bubble subshuttle dock
/:cl:

Adjust mobile docking port to ensure east facing, added stationary docking port.
@Doubleumc Doubleumc requested a review from a team as a code owner October 20, 2023 01:20
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome. labels Oct 20, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 26, 2023
@Erikafox Erikafox added this pull request to the merge queue Nov 17, 2023
Merged via the queue into shiptest-ss13:master with commit 9aab60b Nov 17, 2023
10 checks passed
@Doubleumc Doubleumc deleted the bubble branch November 18, 2023 00:22
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants